<html>
<head><meta charset="utf-8"><title>Meeting 2021-02-23 · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html">Meeting 2021-02-23</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="227303753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227303753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227303753">(Feb 22 2021 at 17:21)</a>:</h4>
<p>Meeting placeholder for <strong>tomorrow</strong> <time datetime="2021-02-23T16:00:00Z">2021-02-23T17:00:00+01:00</time> </p>
<p>Agenda:</p>
<ul>
<li>Triage</li>
<li>Roadmap Project Updates</li>
</ul>
<p>If you got anything else, you want to discuss, just put it below.</p>



<a name="227327285"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227327285" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227327285">(Feb 22 2021 at 19:54)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-clippy/pull/6775">https://github.com/rust-lang/rust-clippy/pull/6775</a> moves <code>upper_case_acronyms</code> from <code>style</code> group to <code>pedantic</code> (which means it no longer warns by default) but <span class="user-mention" data-user-id="219696">@XAMPPRocky</span> had some objections.<br>
I'm not sure if we should revert my pr or not so maybe we could have a quick look at that and see how other people feel about the lint :)</p>



<a name="227451213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227451213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227451213">(Feb 23 2021 at 15:46)</a>:</h4>
<p>Meeting T-14min</p>
<p>Final Agenda:</p>
<ul>
<li>Triage</li>
<li>Roadmap Project Updates</li>
<li><code>upper_case_acronyms</code> categorization</li>
</ul>



<a name="227453665"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227453665" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227453665">(Feb 23 2021 at 16:00)</a>:</h4>
<p>Meeting time <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="227454751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227454751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227454751">(Feb 23 2021 at 16:03)</a>:</h4>
<p>Let's start of with triage: Any issues/PR, we should look at before the sync?</p>



<a name="227454994"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227454994" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Takayuki Nakata <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227454994">(Feb 23 2021 at 16:04)</a>:</h4>
<p>I don't have sync-blocking issues/PRs.</p>



<a name="227455048"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227455048" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227455048">(Feb 23 2021 at 16:04)</a>:</h4>
<p>If not <span class="user-mention" data-user-id="261224">@triagebot</span> end-topic</p>



<a name="227455051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227455051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227455051">(Feb 23 2021 at 16:04)</a>:</h4>
<p>Does anyone have something to add on the current topic?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if not.</p>



<a name="227455179"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227455179" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227455179">(Feb 23 2021 at 16:05)</a>:</h4>
<p>Next up roadmap update: I want to do this regularly in meetings</p>



<a name="227455340"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227455340" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227455340">(Feb 23 2021 at 16:05)</a>:</h4>
<p>The two projects I have on my radar, are the work on </p>
<ul>
<li>lintcheck, mostly by <span class="user-mention" data-user-id="217864">@matthiaskrgr</span> </li>
<li>triage dashboard by <span class="user-mention" data-user-id="316507">@Takayuki Nakata</span></li>
</ul>



<a name="227455566"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227455566" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227455566">(Feb 23 2021 at 16:06)</a>:</h4>
<p>So lintcheck is mostly feature complete, AFAICT. Any plans on features you want to add <span class="user-mention" data-user-id="217864">@matthiaskrgr</span></p>



<a name="227455899"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227455899" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227455899">(Feb 23 2021 at 16:07)</a>:</h4>
<p>Since last week, lintcheck can now collect ICEs that happen and I added parallel execution so that we can check several crates at once (this is opt in via <code>-j </code> flag)</p>



<a name="227456026"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456026" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456026">(Feb 23 2021 at 16:08)</a>:</h4>
<p>Since clippy only checks the root crate and path-deps since recently, I don't expect to find many crashes though</p>



<a name="227456090"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456090" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456090">(Feb 23 2021 at 16:08)</a>:</h4>
<p>Like discussed in the last meeting, I started a separate repo, to run he lintchecks: <a href="https://github.com/flip1995/clippy-lintcheck">https://github.com/flip1995/clippy-lintcheck</a></p>
<p>Currently WIP and ugly code. But I think this is the way to go.</p>



<a name="227456326"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456326" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456326">(Feb 23 2021 at 16:10)</a>:</h4>
<p>Some thinks I have in mind that could be done:<br>
move the code into a seperate crate (<code>lintcheck</code>). I don't think there is a lot of the original <code>clippy dev</code> code that I import and it would make my workflow a bit easier (since I don't have to juggle around with <code> --features lintcheck</code> all the time</p>



<a name="227456400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456400">(Feb 23 2021 at 16:10)</a>:</h4>
<p>we could still keep <code>cargo dev lintcheck</code> as command that does <code>cargo run --bin lintcheck..</code> or something like that though</p>



<a name="227456508"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456508" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456508">(Feb 23 2021 at 16:11)</a>:</h4>
<p>Should we move the lintcheck tool to the repo where we'll keep the logs and config files?</p>



<a name="227456703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456703">(Feb 23 2021 at 16:12)</a>:</h4>
<p>I would still like to have it in the clippy repo to encourage lint-contributors to run it themselves so they can see what impact their lint has</p>



<a name="227456819"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456819" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456819">(Feb 23 2021 at 16:13)</a>:</h4>
<p>Ah, so a separate crate in the clippy repo. Yeah i think that would make sense.</p>



<a name="227456862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456862">(Feb 23 2021 at 16:13)</a>:</h4>
<p>I think the  hack clippy -&gt; add tests -&gt; run lintcheck-&gt; hack clippy -&gt; add more tests from FP found with lintcheck  workflow is quite valuable</p>



<a name="227456892"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456892" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456892">(Feb 23 2021 at 16:13)</a>:</h4>
<p><span class="user-mention silent" data-user-id="264664">flip1995</span> <a href="#narrow/stream/257328-clippy/topic/Meeting.202021-02-23/near/227456819">said</a>:</p>
<blockquote>
<p>Ah, so a separate crate in the clippy repo. Yeah i think that would make sense.</p>
</blockquote>
<p>yes, sorry</p>



<a name="227456924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227456924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227456924">(Feb 23 2021 at 16:13)</a>:</h4>
<p><span class="user-mention" data-user-id="316507">@Takayuki Nakata</span> put some work into a triage dashboard, which you can see in <a href="#narrow/stream/257328-clippy/topic/can.20we.20automate.20triaging.20PRs.20a.20bit.3F/near/227444152">this topic</a></p>
<p><span class="user-mention" data-user-id="316507">@Takayuki Nakata</span> do you host this on github pages or somewhere, where it can already be used or is it only local currently?</p>



<a name="227457093"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227457093" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Takayuki Nakata <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227457093">(Feb 23 2021 at 16:14)</a>:</h4>
<p>Now, it works on only local.</p>



<a name="227457446"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227457446" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Takayuki Nakata <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227457446">(Feb 23 2021 at 16:16)</a>:</h4>
<p>As the next step, I'm thinking I host this dashboard prototype on somewhere.</p>



<a name="227457561"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227457561" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227457561">(Feb 23 2021 at 16:17)</a>:</h4>
<p>That's fine. It definitely looks ready enough, that it could be hosted somewhere. <span class="user-mention" data-user-id="316507">@Takayuki Nakata</span> if you think that it's ready, let me know and we can work on getting it hosted somewhere.</p>



<a name="227457695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227457695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227457695">(Feb 23 2021 at 16:17)</a>:</h4>
<p>Any other Roadmap project updates? <span class="user-mention" data-user-id="261224">@triagebot</span> await</p>



<a name="227457703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227457703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227457703">(Feb 23 2021 at 16:17)</a>:</h4>
<p>Does anyone have something to add on the current topic?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if not.</p>



<a name="227458019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458019">(Feb 23 2021 at 16:18)</a>:</h4>
<p>Ok next up <code>upper_case_acronyms</code> classification. Handing over to <span class="user-mention" data-user-id="217864">@matthiaskrgr</span></p>



<a name="227458054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458054">(Feb 23 2021 at 16:18)</a>:</h4>
<p><a href="https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms">https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms</a></p>



<a name="227458243"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458243" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458243">(Feb 23 2021 at 16:19)</a>:</h4>
<p>The lint was in the <code>style</code> group and warned about  names that hat several capital letters with no lower case letters in between from what I understand.</p>



<a name="227458337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458337">(Feb 23 2021 at 16:20)</a>:</h4>
<p>It seems appropriate for style IMO. But I would feel differently if there is a false positive case?</p>



<a name="227458346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458346">(Feb 23 2021 at 16:20)</a>:</h4>
<p>I counted around 200  lint warnings inside the rustc repo</p>



<a name="227458413"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458413" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458413">(Feb 23 2021 at 16:20)</a>:</h4>
<p>I reviewed the original PR and struggled to classify it. On the one hand it is a naming convention of Rust RFC 430. On the other hand this is really opinionated and will trigger on many peoples code.</p>



<a name="227458486"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458486" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458486">(Feb 23 2021 at 16:21)</a>:</h4>
<p>There was already a bit of a discussion on the PR where I downgraded the lint: <a href="https://github.com/rust-lang/rust-clippy/pull/6775">https://github.com/rust-lang/rust-clippy/pull/6775</a></p>



<a name="227458663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458663">(Feb 23 2021 at 16:22)</a>:</h4>
<p>for example I would not want to rewrite <code>LLVMRustResult</code> to <code>LlvmRustResult</code> (that reads quite badly) but that is also just my opinion :)</p>



<a name="227458720"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458720" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458720">(Feb 23 2021 at 16:22)</a>:</h4>
<p>I'm good with both categories. But I also like <span class="user-mention" data-user-id="217864">@matthiaskrgr</span> suggestion to split the lint and make the part of all-uppercase warn-by-default and the other part allow-by-default</p>



<a name="227458780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458780">(Feb 23 2021 at 16:23)</a>:</h4>
<p>It does seem more picky when acronyms and words are mixed...</p>



<a name="227458813"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458813" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458813">(Feb 23 2021 at 16:23)</a>:</h4>
<p><span class="user-mention silent" data-user-id="217864">matthiaskrgr</span> <a href="#narrow/stream/257328-clippy/topic/Meeting.202021-02-23/near/227458663">said</a>:</p>
<blockquote>
<p>for example I would not want to rewrite <code>LLVMRustResult</code> to <code>LlvmRustResult</code> (that reads quite badly) but that is also just my opinion :)</p>
</blockquote>
<p>Yeah, the second looks indeed really weird</p>



<a name="227458864"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458864" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458864">(Feb 23 2021 at 16:23)</a>:</h4>
<p>Yeah, it can't know when a word is actually an acronym</p>



<a name="227458896"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458896" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458896">(Feb 23 2021 at 16:23)</a>:</h4>
<p>I don't like the lint name and message because it assumes it's an acronym when it might just be an uppercase word</p>



<a name="227458993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227458993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227458993">(Feb 23 2021 at 16:24)</a>:</h4>
<p>which is <a href="https://github.com/rust-lang/rust-clippy/issues/6631">rust-lang/rust-clippy#6631</a></p>



<a name="227459052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459052">(Feb 23 2021 at 16:24)</a>:</h4>
<p>I've checked lintcheck and currently there are 16 cases where we have mixed acronyms and words and only 4 cases where a name is fully capitalized (e.g. <code>WORD</code>)</p>



<a name="227459131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459131">(Feb 23 2021 at 16:25)</a>:</h4>
<p>maybe mixed could be a separate lint?</p>



<a name="227459149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459149">(Feb 23 2021 at 16:25)</a>:</h4>
<p>or configurable?</p>



<a name="227459177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459177">(Feb 23 2021 at 16:25)</a>:</h4>
<p>Oh right, I forgot about <a href="https://github.com/rust-lang/rust/issues/6631">#6631</a>... <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="227459451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459451">(Feb 23 2021 at 16:27)</a>:</h4>
<p>So move it again to <code>style</code> but add a off-by-default aggressive mode config, that will preserve the current behavior and otherwise only lint on all-uppercase names?</p>



<a name="227459458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459458">(Feb 23 2021 at 16:27)</a>:</h4>
<p>so, one lint for FULLCAPITAL and one lint for mixed like LLVMResultSomething?</p>



<a name="227459621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459621">(Feb 23 2021 at 16:28)</a>:</h4>
<p>We could also add a whitelist for terms like <code>ABI</code> or <code>LLVM</code> <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="227459666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459666">(Feb 23 2021 at 16:28)</a>:</h4>
<p>I think that are the two options:</p>
<ol>
<li>split the lint</li>
<li>configuration option</li>
</ol>



<a name="227459728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459728">(Feb 23 2021 at 16:29)</a>:</h4>
<p>Config <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> or separate lint <span aria-label="boom" class="emoji emoji-1f4a5" role="img" title="boom">:boom:</span> ?</p>



<a name="227459797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459797">(Feb 23 2021 at 16:29)</a>:</h4>
<p>imo splitting the lint is more easy to set up via  allow-deny  on the clippy-uses side , mmh</p>



<a name="227459813"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227459813" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227459813">(Feb 23 2021 at 16:29)</a>:</h4>
<p>(you can also control it on individual code-blocks then)</p>



<a name="227460114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460114">(Feb 23 2021 at 16:31)</a>:</h4>
<p>Yeah, I can't really decide what I prefer here. Both options have pros and cons.</p>



<a name="227460305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460305">(Feb 23 2021 at 16:32)</a>:</h4>
<p>But it seems, that most would prefer a config option for it. Any volunteers that want to add that?</p>



<a name="227460539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460539">(Feb 23 2021 at 16:33)</a>:</h4>
<p>Maybe leave it in pedantic until config is added</p>



<a name="227460633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460633">(Feb 23 2021 at 16:34)</a>:</h4>
<p>Well, we're a bit over time, so I would <span class="user-mention" data-user-id="261224">@triagebot</span>  end-meeting.</p>



<a name="227460635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460635">(Feb 23 2021 at 16:34)</a>:</h4>
<p>Unknown command.</p>



<a name="227460666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460666">(Feb 23 2021 at 16:34)</a>:</h4>
<p><span class="user-mention" data-user-id="261224">@triagebot</span> end-meeting</p>



<a name="227460668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460668">(Feb 23 2021 at 16:34)</a>:</h4>
<p>Does anyone have something to bring up?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if you're ready to end the meeting.</p>



<a name="227460718"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460718" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460718">(Feb 23 2021 at 16:34)</a>:</h4>
<p>(you can't put a dot . behind the triagebot command)</p>



<a name="227460735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460735">(Feb 23 2021 at 16:34)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> I never got a A-category label <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="227460882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227460882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227460882">(Feb 23 2021 at 16:35)</a>:</h4>
<p>Oh, I'll add that now. I've gone over your list like 5 times and still forgot it <span aria-label="smiley" class="emoji emoji-1f603" role="img" title="smiley">:smiley:</span></p>



<a name="227461010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227461010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227461010">(Feb 23 2021 at 16:36)</a>:</h4>
<p>A-category or L-category?</p>



<a name="227461078"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227461078" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227461078">(Feb 23 2021 at 16:36)</a>:</h4>
<p>Anyway, thanks everyone for attending! <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="227461139"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227461139" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227461139">(Feb 23 2021 at 16:37)</a>:</h4>
<p>A-category</p>



<a name="227461151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227461151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227461151">(Feb 23 2021 at 16:37)</a>:</h4>
<p>Thank you for running the meeting again <span class="user-mention" data-user-id="264664">@flip1995</span> <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="227461503"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-23/near/227461503" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-23.html#227461503">(Feb 23 2021 at 16:39)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-clippy/labels?q=A-category">https://github.com/rust-lang/rust-clippy/labels?q=A-category</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>